Update guides/source/plugins.md [ci skip] #30261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pixeltrix (@rails-bot has picked a reviewer for you, use r? to override) |
yhirano55
reviewed
Aug 15, 2017
guides/source/plugins.md
Outdated
| @@ -458,13 +449,13 @@ Gem plugins currently in development can easily be shared from any Git repositor | |||
| commit the code to a Git repository (like GitHub) and add a line to the Gemfile of the application in question: | |||
|
|
|||
| ```ruby | |||
| gem 'yaffle', git: 'git://github.com/yaffle_watcher/yaffle.git' | |||
| gem "yaffle", git: "git://github.com/rails/yaffle.git" | |||
There was a problem hiding this comment.
@bogdanvlviv Could you change to https protocol from git protocol? (And I'll close a request #30262) Thanks for your great work.
There was a problem hiding this comment.
@yhirano55 Thanks
bogdanvlviv
force-pushed
the
improve-guides-plugins
branch
from
f895641
to
87666e5
Compare
| @@ -458,13 +449,13 @@ Gem plugins currently in development can easily be shared from any Git repositor | |||
| commit the code to a Git repository (like GitHub) and add a line to the Gemfile of the application in question: | |||
|
|
|||
| ```ruby | |||
| gem 'yaffle', git: 'git://github.com/yaffle_watcher/yaffle.git' | |||
| gem "yaffle", git: "https://github.com/rails/yaffle.git" | |||
There was a problem hiding this comment.
can we keep the link outside the rails org?
There was a problem hiding this comment.
I've changed it guided by that one day there might be a user by https://github.com/yaffle_watcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.