Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete explanation about passing string to :if and :unless [ci skip] #30295

Merged
merged 1 commit into from
Aug 17, 2017

Conversation

ohbarye
Copy link
Contributor

@ohbarye ohbarye commented Aug 17, 2017

This is a follow up to #28058.

Passing String is already oblsote since #27608

about passing string to `:if` and `:unless`.
This is a follow up to rails#28058 [ci
skip]
@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@maclover7 maclover7 merged commit d1c03d3 into rails:master Aug 17, 2017
@maclover7
Copy link
Contributor

👍 Thank you for your contribution!

❤️ 💚 💙 💛 💜

@ohbarye ohbarye deleted the follow_up_to_28058 branch August 17, 2017 15:23
@ohbarye
Copy link
Contributor Author

ohbarye commented Aug 17, 2017

@maclover7
Thank you for your fast review! ❤️ 💚 💙 💛 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants