Use REDIS_URL var for Action Cable config template #30366
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
| @@ -6,5 +6,5 @@ test: | |||
|
|
|||
| production: | |||
| adapter: redis | |||
| url: redis://localhost:6379/1 | |||
| url: <%%= ENV.fetch("REDIS_URL") { "redis://localhost:6379/1" } %> | |||
There was a problem hiding this comment.
I took as guide the other templates, @palkan, see the following: postgresql.yml
Honestly, I don't know how it works, but I think is kind of "escaping" the ERB interpolation.
There was a problem hiding this comment.
Oh, right, we're inside a template which is ERB-processed too. Sorry, everything is correct)
That's the way it works–link.
ghost
deleted the
Summary
Use environment variables in the action cable configuration, using the common
REDIS_URLtoconfigure it, and if is not set, fallback to the default configuration (localhost).
This doesn't fix any bugs, however, today we had a small downtime because we missed the
Action Cableconfiguration, I found this tweak useful.