Remove Active Storage duplicated classes from the API site #30426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since cb5af0d, some classes that are under Active Storage are now part of the API site. However, these classes aren't nested under a definition of the `ActiveStorage` module but rather name-spaced under it like `ActiveStorage::Foo`. Thus, these classes are present both under the ActiveStorage label and at the root of the site's sidebar so we have to strip out duplicates. [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Since cb5af0d, some classes that are under Active Storage are now part of the API site.
However, these classes aren't nested under a definition of the
ActiveStoragemodule but rather name-spaced under it likeActiveStorage::Foo.Thus, these classes are present both under the ActiveStorage label and at the root of the site's sidebar so we have to strip out duplicates.
Have a nice day !