Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that bulk option is supported only by MySQL #30445

Merged
merged 1 commit into from
Aug 28, 2017
Merged

Clarify that bulk option is supported only by MySQL #30445

merged 1 commit into from
Aug 28, 2017

Conversation

prathamesh-sonpatki
Copy link
Member

kaspth
kaspth reviewed Aug 28, 2017
View reviewed changes
activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb Outdated
@@ -405,6 +405,8 @@ def drop_join_table(table_1, table_2, options = {})
# ALTER TABLE `users` ADD COLUMN age INT, ADD COLUMN birthdate DATETIME ...
#
# Defaults to false.
# This is supported only by MySQL adapter. Rest of the adapters will just ignore
# the <tt>:bulk</tt> option.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with:

#   Defaults to false.
#
#   Only supported on the MySQL adapter, ignored elsewhere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaspth Hi! Done 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 😄

@kaspth kaspth merged commit 99f7582 into rails:master Aug 28, 2017
@prathamesh-sonpatki prathamesh-sonpatki deleted the fix-30441 branch August 28, 2017 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspth kaspth kaspth left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prathamesh-sonpatki @kaspth