Update Caching with Rails guide [ci skip] #30447

yhirano55 · 2017-08-28T21:45:38Z

Summary

Added quotations on L178 and L287.
Changed to single quote same as others on L275 and L287.

rails-bot · 2017-08-28T21:45:40Z

(@rails-bot has picked a reviewer for you, use r? to override)

kamipo · 2017-08-29T11:27:05Z

guides/source/caching_with_rails.md

@@ -284,7 +284,7 @@ class Product < ApplicationRecord
 end
 ```

-NOTE: Notice that in this example we used the `cache_key` method, so the resulting cache-key will be something like `products/233-20140225082222765838000/competing_price`. `cache_key` generates a string based on the model’s `id` and `updated_at` attributes. This is a common convention and has the benefit of invalidating the cache whenever the product is updated. In general, when you use low-level caching for instance level information, you need to generate a cache key.
+NOTE: Notice that in this example we used the `cache_key` method, so the resulting `cache-key` will be something like `products/233-20140225082222765838000/competing_price`. `cache_key` generates a string based on the model's `id` and `updated_at` attributes. This is a common convention and has the benefit of invalidating the cache whenever the product is updated. In general, when you use low-level caching for instance level information, you need to generate a cache key.


I feel that it should be the resulting cache-key, not the resulting `cache-key`.

Partial reverted in c4e576f.

Update Caching with Rails guide [ci skip]

ddc8f43

rails-bot assigned kamipo Aug 28, 2017

eileencodes merged commit 07402aa into rails:master Aug 29, 2017

kamipo reviewed Aug 29, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Caching with Rails guide [ci skip] #30447

Update Caching with Rails guide [ci skip] #30447

yhirano55 commented Aug 28, 2017

rails-bot commented Aug 28, 2017

kamipo Aug 29, 2017

kamipo Aug 29, 2017

Update Caching with Rails guide [ci skip] #30447

Update Caching with Rails guide [ci skip] #30447

Conversation

yhirano55 commented Aug 28, 2017

Summary

rails-bot commented Aug 28, 2017

kamipo Aug 29, 2017

Choose a reason for hiding this comment

kamipo Aug 29, 2017

Choose a reason for hiding this comment