activerecord: Remove a redundant mutation tracker #30471
Conversation
The extra mutation tracker was needed in Rails 5.1 to preserve the old behaviour of `changes`, but now there is no difference between `changes` and `changes_to_save`, so `@mutation_tracker` can be removed.
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @javan (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
|
r? @sgrif |
cc @sgrif
Pull request #25337 added an extra mutation tracker to preserve the old
changesbehaviour, but now thatchangesbehaves the same way aschanges_to_save(020abad), we don't need both@mutation_trackerand@mutations_from_database. In fact, the only time they reference a different object is withinchanges_appliedwhere it made the assignment@mutations_from_database = AttributeMutationTracker.new(@attributes)but then it calledclear_mutation_trackerswhich set both@mutation_trackerand@mutations_from_database`` tonil`.This PR removes
@mutation_trackerand instead just uses@mutations_from_database.