Use credentials, not secrets, for Active Storage #30650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a conflict? |
|
Related #30648 |
According to rails#30067: > This PR will deprecate secrets.yml* and instead adopt > config/credentials.yml.enc to signify what these secrets are specifically > for: Keeping API keys, database passwords, and any other integration > credentials in one place. [ci skip] since only comments are being edited.
claudiob
force-pushed
the
use-credentials-not-secrets
branch
from
d857e56
to
e7d24bb
Compare
|
@dhh Conflict solved |
y-yagi
added a commit
to y-yagi/rails
that referenced
this pull request
Sep 19, 2017
Follow up of rails#30650
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #30067 (@dhh / @kaspth) :
Therefore the examples for Active Storage should indicate
Rails.application.credentialsand notRails.application.secrets.Additionally, the template for the credentials file should have an
awskey, and not anamazonkey, since that's what the example config/storage.yml file expects.