make create_join_table compatible. #30655
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @georgeclaghorn (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
|
|
|
Can you change this PR target against master branch? |
|
Do it. thx. |
kuzukuzu
force-pushed
the
fix_create_join_table_compatibility
branch
from
cb18017
to
4007684
Compare
| yield t | ||
| end | ||
| else | ||
| super(table_1, table_2, column_options: column_options.reverse_merge!(type: :integer), **options) |
There was a problem hiding this comment.
We can simply call super if column_options.reverse_merge!(type: :integer) before if-else block.
kuzukuzu
force-pushed
the
fix_create_join_table_compatibility
branch
from
4007684
to
0c8bed9
Compare
…bility make create_join_table compatible.
Follow up of #28217 .
Fix #30654 .