Ensure 1 AS one for SQL Server with Calculations
#30686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pixeltrix (@rails-bot has picked a reviewer for you, use r? to override) |
kamipo
pushed a commit
that referenced
this pull request
Sep 26, 2017
Ensure `1 AS one` for SQL Server with Calculations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the work done in #29848 a regression was caused for SQL Server where derived tables need to create references to column names. For example, this simple calculation example fails, with VS Code screenshot to latest SQL Server on Linux connection.
The fix is simple, we can use
1 AS onewhich is even referenced in a const already but in another module. Open to alternatives if the usage is not ideal. Also, it would be super cool if this could be applied to 5-1-stable since v5.1.4 is now broken for us. Thanks so much for whomever's time on this too. Thanks y'all!!!cc @kamipo