Testing actioncable against websocket-driver 0.7.0 #30711
Conversation
|
(@rails-bot has picked a reviewer for you, use r? to override) |
|
Looks like the tests mostly pass. I'm not sure how reliable CI is .. are the failures intermittent? I don't know b/c I don't have permissions to retry a CI job. |
|
@dhh Please assign someone to review this. I have no idea who to ask. Thanks. |
|
Why are we trying to run against the newer websocket-driver? |
|
This is due to me commenting that this version fixed a bug that was reported earlier, but it turns out that fix did not make it into this version. It is still unreleased. and So it might not be worth updating to 0.7.0 now, but it would be good to see if a new version of websocket-driver could be released to fix that bug. |
|
I'm generally happy to see looser Gem bindings. So I'd take one that's just
open ended. Just specify our minimum required version.
…On Thu, Jan 18, 2018 at 12:54 PM, Ian Suda ***@***.***> wrote:
This is due to me commenting that this version fixed a bug that was
reported earlier, but it turns out that fix did not make it into this
version. It is still unreleased.
#30908 <#30908>
and
faye/websocket-driver-ruby#58
<faye/websocket-driver-ruby#58>
***@***.***
<faye/websocket-driver-ruby@2ec898c>
So it might not be worth updating to 0.7.0 now, but it would be good to
see if a new version of websocket-driver could be released to fix that bug.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30711 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAKtbrt-5OWHVn57o5r-9c-E92ih38Oks5tL5NKgaJpZM4Pi7oH>
.
|
actioncable/actioncable.gemspec
Outdated
| @@ -28,5 +28,5 @@ Gem::Specification.new do |s| | |||
| s.add_dependency "actionpack", version | |||
|
|
|||
| s.add_dependency "nio4r", "~> 2.0" | |||
| s.add_dependency "websocket-driver", "~> 0.6.1" | |||
| s.add_dependency "websocket-driver", [">= 0.6.1", "< 0.8"] | |||
There was a problem hiding this comment.
Can you change it to >= 0.6.1?
I just want to run the CI, I haven't done any analysis of changes in websocket-driver 0.7.0. I haven't even read their changelog. This PR is just to cause a CI run, but if people want to use it as a starting point for discussion, that's fine too.
Changed, thanks. |
This PR is just to cause a CI run, but if people want to use it as a starting point for discussion, that's fine too.
The changelog for websocket-driver 0.7.0 does not mention any breaking changes.