Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "warning: method redefined; discarding old test_scaffold_plural_names" #30755

Merged
merged 1 commit into from
Sep 30, 2017

Conversation

y-yagi
Copy link
Member

@y-yagi y-yagi commented Sep 29, 2017

Since warning was issued due to duplication of test names, fix the test name to a meaningful name.

This fixes following warnings:

railties/test/generators/named_base_test.rb:141: warning: method redefined; discarding old test_scaffold_plural_names
railties/test/generators/named_base_test.rb:62: warning: previous definition of test_scaffold_plural_names was here

…ames"

Since warning was issued due to duplication of test names, fix the test
name to a meaningful name.

This fixes following warnings:

```
railties/test/generators/named_base_test.rb:141: warning: method redefined; discarding old test_scaffold_plural_names
railties/test/generators/named_base_test.rb:62: warning: previous definition of test_scaffold_plural_names was here
```
@rails-bot
Copy link

r? @pixeltrix

(@rails-bot has picked a reviewer for you, use r? to override)

@kamipo kamipo merged commit c97a5ad into rails:master Sep 30, 2017
@y-yagi y-yagi deleted the fix_method_refined_warning branch September 30, 2017 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants