Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use form_with instead of form_for in engine guide [ci skip] #30839

Merged
merged 1 commit into from Oct 9, 2017

Conversation

yhirano55
Copy link
Contributor

Summary

  • Currently, in scaffold generator, it use form_with instead of form_for. So I think that it's better to replace form_for with form_with in the guide.
  • And partial file app/views/blorgh/articles/_form.html.erb is actually defined as form_with. So I replaced f.label with form.label. Because the block argument is not f but form. Please check here.

@rails-bot
Copy link

r? @kamipo

(@rails-bot has picked a reviewer for you, use r? to override)

@kamipo
Copy link
Member

kamipo commented Oct 9, 2017

We have form_for example not only in the engine guide but also in another guides (action_controller_overview.md, action_view_overview.md, etc.).
Can you take also a look at another guides?

@yhirano55 yhirano55 force-pushed the use_form_with_in_engine_guide branch from e19cac0 to 639fded Compare October 9, 2017 02:36
@yhirano55
Copy link
Contributor Author

@kamipo I added changes for the guide of Action Controller Overview. In the guide of Action View Overview, it describes FormHelper itself, so I thought it's better to make it fix in another PR.

@kamipo kamipo merged commit 992572a into rails:master Oct 9, 2017
@yhirano55 yhirano55 deleted the use_form_with_in_engine_guide branch October 9, 2017 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants