Improved logging of AJ's DelayedJob wrapper #30879
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kamipo (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
jalapl
changed the title
|
r? @matthewd |
| skip unless adapter_is?(:delayed_job) | ||
| ::HelloJob.perform_later | ||
| job = Delayed::Job.first | ||
| assert job.name =~ /HelloJob \[[0-9a-f-]+\] from DelayedJob\(default\) with arguments: \[\]/ |
There was a problem hiding this comment.
Could you used assert_match?
There was a problem hiding this comment.
@rafaelfranca
Sure, I've just changed it. 👍
ActiveJob wraps every adapter into its own class, that is later passed into DelayedJob which is responsible for displaying all the logs. This change improves the logging so we can easily trace executed jobs and see meaningful information in the logs.
Summary
ActiveJob wraps every adapter into its own class, that is later passed into DelayedJob which is responsible for displaying all the logs.
This change improves the logging so we can easily trace executed jobs and see meaningful information in the logs.