Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clear that Time core extensions are split between Numeric and Integer #30972

Merged

Conversation

jcmfernandes
Copy link
Contributor

@jcmfernandes jcmfernandes commented Oct 24, 2017

Summary

The documentation wrongly suggests that Time extensions to Numeric include
methods months and years, when these belong to Integer.

Update both classes and guides.

Fixes #30971.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

…teger

The documentation wrongly suggests that Time extensions to Numeric include
methods months and years, when these belong to Integer.

Update both classes and guides.
@jcmfernandes jcmfernandes force-pushed the update-core_ext-time-documentation branch from 744e91f to d863702 Compare October 24, 2017 14:32
@rafaelfranca rafaelfranca merged commit 453ab17 into rails:master Oct 24, 2017
bogdanvlviv added a commit to bogdanvlviv/rails that referenced this pull request Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants