Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5_1_release_notes include more removals [ci skip] #30996

Merged
merged 1 commit into from Oct 28, 2017
Merged

5_1_release_notes include more removals [ci skip] #30996

merged 1 commit into from Oct 28, 2017

Conversation

tscoville2012
Copy link
Contributor

Updated 5_1_release_notes.md to include support to :text and :nothing in render

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@@ -350,6 +350,10 @@ Please refer to the [Changelog][action-pack] for detailed changes.

* Removed deprecated methods related to controller filters.
([Commit](https://github.com/rails/rails/commit/d7be30e8babf5e37a891522869e7b0191b79b757))

* Removed deprecated support to :text and :nothing in render.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:text and :nothing in render.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@kamipo
Copy link
Member

kamipo commented Oct 27, 2017

Looks good. Could you please squash your commits into one?

@eileencodes eileencodes merged commit e4eaf8f into rails:master Oct 28, 2017
@tscoville2012 tscoville2012 deleted the tscoville2012-patch-1 branch October 28, 2017 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants