Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for ActionMailer failures by not installing mail 2.7 #31026

Merged
merged 1 commit into from Nov 1, 2017
Merged

Workaround for ActionMailer failures by not installing mail 2.7 #31026

merged 1 commit into from Nov 1, 2017

Conversation

yahonda
Copy link
Member

@yahonda yahonda commented Nov 1, 2017 •
edited

Summary

This pull request should workaround these 4 failures reported at https://travis-ci.org/rails/rails/jobs/295571582

TestHelperMailerTest#test_encode
BaseTest#test_implicit_multipart_with_attachments_creates_nested_parts
BaseTest#test_implicit_multipart_with_attachments_and_sort_order
BaseTest#test_explicit_multipart_with_attachments_creates_nested_parts

This should be a workaround commit to make CI green.

cc @y-yagi

@yahonda
Workaround for ActionMailer failures by not installing mail 2.7
14b7d67 
```ruby
TestHelperMailerTest#test_encode
BaseTest#test_implicit_multipart_with_attachments_creates_nested_parts
BaseTest#test_implicit_multipart_with_attachments_and_sort_order
BaseTest#test_explicit_multipart_with_attachments_creates_nested_parts
```
Refer https://travis-ci.org/rails/rails/jobs/295571582
@rails-bot
Copy link

r? @eileencodes

(@rails-bot has picked a reviewer for you, use r? to override)

@y-yagi
Copy link
Member

y-yagi commented Nov 1, 2017

@yahonda Thanks!!

@jeremy Mail 2.7.0 has broken some Action Mailer tests. Is this intentional changes?

@rafaelfranca
Copy link
Member

I don't think it was intentional. Our bad since we should be testing the pre release version of mail. I'll merge this in so it unblocks other PRs and we can investigate later.

@rafaelfranca rafaelfranca merged commit 4d96be1 into rails:master Nov 1, 2017
@yahonda yahonda deleted the diag_mail27 branch November 1, 2017 03:17
@jeremy
Copy link
Member

jeremy commented Nov 1, 2017

Oops, thanks @yahonda! Fixed @ 0931e17

jeremy added a commit that referenced this pull request Nov 1, 2017
@jeremy
Fix tests on Mail 2.7
0931e17 
Reverts 4d96be1
References #31026
eileencodes added a commit that referenced this pull request Dec 7, 2017
@eileencodes
Fix mail tests on Rails 4.2
b8935e4 
An update to mail broke some tests on Rails. Originally they were
unblocked here #31026 but Jeremy fixed them for Mail 2.7 in
0931e17.

I wasn't able to cleanly backport this so I'm doing it manually. Fixes
the failing Rails 4.2 build on travis.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eileencodes eileencodes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yahonda @rails-bot @y-yagi @rafaelfranca @jeremy @eileencodes