Fix guides build #31039
Merged
Fix guides build #31039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(@rails-bot has picked a reviewer for you, use r? to override) |
y-yagi
force-pushed
the
fix_guides_build
branch
7 times, most recently
from
43f4edc
to
5ba800d
Compare
|
I prefer this change since we can run CI using the latest version of Bundler 1.16.0 by isolating guides. |
|
Is this change necessary for |
We have already specified to install `bundler` 1.15.4 in `.travis.yml`. https://github.com/rails/rails/blob/master/.travis.yml#L31..L32 However, `bundler` 1.16.0 may be used in the test. https://travis-ci.org/rails/rails/jobs/296582467#L2208 The test failed due to this influence. In order to avoid this, specifying `bundler` version in bug report templates.
y-yagi
force-pushed
the
fix_guides_build
branch
from
5ba800d
to
b106242
Compare
I think that it is correct. However, since |
|
Confirmed the running bug templates has passed. |
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Nov 10, 2017
Related with rails/rails#31039 $ ruby -v ruby 2.4.2p198 (2017-09-14 revision 59899) [x86_64-linux] $ bundler -v Bundler version 1.16.0 $ ```ruby $ cd guides/bug_report_templates/ $ ruby active_record_gem.rb ... snip ... /home/yahonda/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/runtime.rb:28:in `block in setup': rake-12.2.1 is missing. Run `bundle install` to get it. (Bundler::GemNotFound) from /home/yahonda/.rbenv/versions/2.4.2/lib/ruby/2.4.0/forwardable.rb:229:in `each' from /home/yahonda/.rbenv/versions/2.4.2/lib/ruby/2.4.0/forwardable.rb:229:in `each' from /home/yahonda/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/runtime.rb:26:in `map' from /home/yahonda/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/runtime.rb:26:in `setup' from /home/yahonda/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/inline.rb:70:in `gemfile' from active_record_gem.rb:10:in `<main>' $ ``` ```ruby $ ruby active_record_gem_spec.rb ... snip ... /home/yahonda/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/runtime.rb:28:in `block in setup': rake-12.2.1 is missing. Run `bundle install` to get it. (Bundler::GemNotFound) from /home/yahonda/.rbenv/versions/2.4.2/lib/ruby/2.4.0/forwardable.rb:229:in `each' from /home/yahonda/.rbenv/versions/2.4.2/lib/ruby/2.4.0/forwardable.rb:229:in `each' from /home/yahonda/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/runtime.rb:26:in `map' from /home/yahonda/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/runtime.rb:26:in `setup' from /home/yahonda/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/inline.rb:70:in `gemfile' from active_record_gem_spec.rb:10:in `<main>' $ ```
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Nov 10, 2017
Related to rails/rails#31039 $ ruby -v ruby 2.4.2p198 (2017-09-14 revision 59899) [x86_64-linux] $ bundler -v Bundler version 1.16.0 $ ```ruby $ cd guides/bug_report_templates/ $ ruby active_record_gem.rb ... snip ... /home/yahonda/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/runtime.rb:28:in `block in setup': rake-12.2.1 is missing. Run `bundle install` to get it. (Bundler::GemNotFound) from /home/yahonda/.rbenv/versions/2.4.2/lib/ruby/2.4.0/forwardable.rb:229:in `each' from /home/yahonda/.rbenv/versions/2.4.2/lib/ruby/2.4.0/forwardable.rb:229:in `each' from /home/yahonda/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/runtime.rb:26:in `map' from /home/yahonda/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/runtime.rb:26:in `setup' from /home/yahonda/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/inline.rb:70:in `gemfile' from active_record_gem.rb:10:in `<main>' $ ``` ```ruby $ ruby active_record_gem_spec.rb ... snip ... /home/yahonda/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/runtime.rb:28:in `block in setup': rake-12.2.1 is missing. Run `bundle install` to get it. (Bundler::GemNotFound) from /home/yahonda/.rbenv/versions/2.4.2/lib/ruby/2.4.0/forwardable.rb:229:in `each' from /home/yahonda/.rbenv/versions/2.4.2/lib/ruby/2.4.0/forwardable.rb:229:in `each' from /home/yahonda/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/runtime.rb:26:in `map' from /home/yahonda/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/runtime.rb:26:in `setup' from /home/yahonda/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/inline.rb:70:in `gemfile' from active_record_gem_spec.rb:10:in `<main>' $ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Specify bundler version in template files.
We have already specified to install
bundler1.15.4 in.travis.yml.https://github.com/rails/rails/blob/master/.travis.yml#L31..L32
However,
bundler1.16.0 may be used in the test.https://travis-ci.org/rails/rails/jobs/296582467#L2208
The test failed due to this influence.
In order to avoid this, specifying
bundlerversion in bug report templates.