Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typoes on ActionDispatch::HTTP::FilterParameters #31078

Merged
merged 1 commit into from Nov 9, 2017

Conversation

aeroastro
Copy link
Contributor

Summary

I have fixed 2 typoes on the comment of ActionDispatch::HTTP::FilterParameters

  • Add a continuative relative pronoun and an additional definite article for more understandable document.
  • Use present tense on method description.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@aeroastro aeroastro changed the title [ci skip] Fix typoes on ActionDispatc::HTTP::FilterParameters [ci skip] Fix typoes on ActionDispatch::HTTP::FilterParameters Nov 7, 2017
@aeroastro aeroastro changed the title [ci skip] Fix typoes on ActionDispatch::HTTP::FilterParameters Fix typoes on ActionDispatch::HTTP::FilterParameters Nov 7, 2017
@rafaelfranca rafaelfranca merged commit 25f926f into rails:master Nov 9, 2017
@aeroastro aeroastro deleted the feature/fix-typo branch November 9, 2017 07:59
@aeroastro
Copy link
Contributor Author

Thank you for merging this.
🐱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants