Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AR update_attributes api is updated to reflect the addition of assign_att #311

Closed
wants to merge 1 commit into from
Closed

AR update_attributes api is updated to reflect the addition of assign_att #311

wants to merge 1 commit into from

Conversation

joshk
Copy link
Contributor

@joshk joshk commented Apr 26, 2011

Hey Guys,

This brings AR update_attributes in line with assign_attributes in accepting a scope using :as or bypass mass-assignment security using :without_protection => true

Thanks,

J

martinploeger pushed a commit to martinploeger/rails that referenced this pull request Apr 26, 2011
AR update_attributes api is updated to reflect the addition of assign_att
@tenderlove
Copy link
Member

Merged, thanks!

@tenderlove tenderlove closed this Apr 26, 2011
@tenderlove tenderlove reopened this Apr 26, 2011
@tenderlove
Copy link
Member

Or maybe not merged! I am confused!

@joshk
Copy link
Contributor Author

joshk commented Apr 26, 2011

its merged, its in the commits list :)

for some reason GH doesn't close pull requests automagically :(

@tenderlove
Copy link
Member

Ok. I'll close this. Thanks for verifying!

@tenderlove tenderlove closed this Apr 26, 2011
arunagw pushed a commit to arunagw/rails that referenced this pull request Apr 26, 2011
AR update_attributes api is updated to reflect the addition of assign_att
matthewd pushed a commit that referenced this pull request Apr 24, 2018
`Extract#as` should not mutate the receiver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants