Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort mailer previews alphabetically #31145

Merged
merged 1 commit into from Nov 13, 2017
Merged

Sort mailer previews alphabetically #31145

merged 1 commit into from Nov 13, 2017

Conversation

dwightwatson
Copy link
Contributor

Summary

This fixes an issue where the index page of mailer previews was not sorted in any meaningful way. It appears as though the methods underneath each mailer are sorted alphabetically but the mailers themselves are not.

Now all the mailers will be ordered alphabetically along with their methods which is more predictable and expected.

Other Information

Here's a screenshot from my preview index as-is, where you can see the mailers are not in any obvious order.

image

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@rafaelfranca rafaelfranca merged commit 8fad56c into rails:master Nov 13, 2017
@dwightwatson dwightwatson deleted the feature/preview-sorting branch November 13, 2017 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants