Extract sql fragment generators from PostgreSQL adapter #31230
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @georgeclaghorn (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
dinahshi
force-pushed
the
postgresql_extract_sql
branch
from
bfc66d8
to
69510cf
Compare
dinahshi
force-pushed
the
postgresql_extract_sql
branch
from
69510cf
to
dd6338a
Compare
Since #31230, `change_column` is executed as a bulk statement. That caused incorrect type casting column default by looking up the before changed type, not the after changed type. In a bulk statement, we can't use `change_column_default_for_alter` if the statement changes the column type. This fixes the type casting to use the constructed target sql_type. Fixes #34938.
Since #31230, `change_column` is executed as a bulk statement. That caused incorrect type casting column default by looking up the before changed type, not the after changed type. In a bulk statement, we can't use `change_column_default_for_alter` if the statement changes the column type. This fixes the type casting to use the constructed target sql_type. Fixes #34938.
This change introduces a layer of "#{command}_sql" helpers that generate sql
fragments, leaving public methods like :change_column as a "ALTER TABLE #{x}"
shell. This refactor is in preparation for supporting
change_table bulk:trueAlso changes Postgres adapter's
:change_columnto not apply update whenpassed null and default to mirror MySQL and SQLite adapters.
:change_column_nullstill applies update.