url_for skip params which given as defaults

[distroid]

Steps to reproduce

I use STI model and one controller with type for initialize different resources:

resources :partners, controller: :companies, defaults: { type: 'Partner' }
resources :providers, controller: :companies, defaults: { type: 'Provider' }

Routes works as expected for CRUD

For pagination i use kaminari. I think problem in helper method url_for he ignored overrided params from defaults and always return url with first initialized route (currently it's partners).

For example:

paginate @records, params: { type: 'Provider' }

It's will be ignored and type skipped.

Expected behavior

For /partners in pagination should be /partners?page=<number>
For /providers in pagination should be /providers?page=<number>

Actual behavior

For /partners in pagination i get /partners?page=<number>
For /providers i also get /partners?page=<number>

System configuration

Rails version:
Rails 5.1.4

Ruby version:
ruby 2.3.4p301 (2017-03-30 revision 58214) [x86_64-darwin16]

Related #27132

[y-yagi]

Can you please provide a sample application that reproduces the error?

[distroid]

@y-yagi sure, I will do this and add here a link

[pixeltrix]

@distroid why not use a CompaniesController parent class and subclasses for PartnersController and ProvidersController ? You can then drop the :type param from url_for and it will use the correct controller.

[distroid]

@pixeltrix yes, you right, it's will be work. But i think :type should work for my case. Because controllers with :type works as expected and bug only with pagination or generate url by url_for.
url_for always skipped defaults params.

[pixeltrix]

@distroid as I explained in #27132 this will be a change of behaviour and will result in people's apps generating different routes - something we can consider for Rails 6 maybe.

[rails-bot]

This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails team are limited, and so we are asking for your help.
If you can still reproduce this error on the 5-1-stable branch or on master, please reply with all of the information you have about it in order to keep the issue open.
Thank you for all your contributions.