Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assert_in_epsilon to Testing guide [ci skip] #31345

Merged

Conversation

yhirano55
Copy link
Contributor

@yhirano55 yhirano55 commented Dec 6, 2017

Summary

I found assert_in_epsilon is not be in 2.4 Available Assertions.
So I Added them.

MiniTest::Assertions#assert_in_epsilon:

https://github.com/seattlerb/minitest/blob/master/lib/minitest/assertions.rb#L204-L210

Screenshot

I've confirmed a html document generated by bundle exec rake guides:generate:html:

image

I found `assert_in_epsilon` is not be in "2.4 Available Assertions".
So I Added them.

MiniTest::Assertions#assert_in_epsilon:

https://github.com/seattlerb/minitest/blob/master/lib/minitest/assertions.rb#L204-L210
@rails-bot
Copy link

r? @georgeclaghorn

(@rails-bot has picked a reviewer for you, use r? to override)

@eileencodes eileencodes merged commit ce37e16 into rails:master Dec 6, 2017
@yhirano55 yhirano55 deleted the add_assert_in_epsilon_to_testing_guide branch December 6, 2017 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants