Fix Rails environment when running tests with Ruby #31355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenderlove
force-pushed
the
fix-rails-env-with-ruby
branch
from
0e033df
to
a73efe4
Compare
rafaelfranca
reviewed
Dec 7, 2017
| time: result.time) | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
There are trailing whitespaces here.
There was a problem hiding this comment.
Thanks! I saw the complaints, but Vim didn't show for some reason. 😀
rafaelfranca
reviewed
Dec 7, 2017
| Minitest.reporter.reporters.clear | ||
| Minitest.reporter.reporters << JSONReporter.new | ||
| end | ||
|
|
There was a problem hiding this comment.
There are trailing whitespaces here.
I frequently run tests with `ruby`, not with a runner like `rake` or `rails`. When running the test with just `ruby` the `RAILS_ENV` environment variable did not get set to "test", and this would cause the tests to fail (and even mutate the development database!) This commit adds integration tests for running tests with just `ruby` and ensures the environment gets defaulted to "test". I also added a test to ensure that passing an environment to `-e` actually works (and fixed that case too). An interesting / annoying thing is that Minitest picks up it's plugins by asking RubyGems for a list of files: https://github.com/seattlerb/minitest/blob/ca6a71ca901016db09a5ad466b4adea4b52a504a/lib/minitest.rb#L92-L100 This means that RubyGems needs to somehow know about the file before it can return it to Minitest. Since we are not packaging Rails as a Gem before running the integration tests on it (duh, why would you do that?), RubyGems doesn't know about the file, so it can't tell Minitest, so Minitest doesn't automatically require it. This means I had to manually require and insert the plugin in our integration test. I've left comments about that in the test as well. Ugh.
tenderlove
force-pushed
the
fix-rails-env-with-ruby
branch
from
a73efe4
to
da225c0
Compare
eileencodes
approved these changes
Dec 7, 2017
eileencodes
requested changes
Dec 7, 2017
|
Ah doesn't work for me either :(. I think it's already too late to set the ENV side the runner when using ruby or even rake because we already loaded the gems I think we can add rails/railties/lib/rails/test_unit/railtie.rb Lines 5 to 7 in bbacd60 |
|
Ah, so this patch is setting the ENV correctly, it's just too late. sigh @Edouard-chin I think we used to have something like that. We really need a test for this case though because the behavior breaks too often for my liking 😉 |
When tests are run with just `ruby`, the RAILS_ENV is set to `development` too early, and we connect to the development database rather than the test database.
This reverts commit 9a80f52.
Option parsing happens too late to have any impact on the Rails environment. Rails accesses the environment name and memoizes it too early in the boot process for a commandline option to have any impact on the database connection, so we'll change this test to set the environment from an environment variable (and ensure it still works when running tests with `ruby`)
tenderlove
force-pushed
the
fix-rails-env-with-ruby
branch
from
3523d80
to
a50b8ea
Compare
tenderlove
added a commit
that referenced
this pull request
Dec 8, 2017
Fix Rails environment when running tests with Ruby
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I frequently run tests with
ruby, not with a runner likerakeorrails. When running the test with justrubytheRAILS_ENVenvironment variable did not get set to "test", and this would cause the
tests to fail (and even mutate the development database!)
This commit adds integration tests for running tests with just
rubyand ensures the environment gets defaulted to "test". I also added a
test to ensure that passing an environment to
-eactually works (andfixed that case too).
An interesting / annoying thing is that Minitest picks up it's plugins
by asking RubyGems for a list of files:
https://github.com/seattlerb/minitest/blob/ca6a71ca901016db09a5ad466b4adea4b52a504a/lib/minitest.rb#L92-L100
This means that RubyGems needs to somehow know about the file before it
can return it to Minitest. Since we are not packaging Rails as a Gem
before running the integration tests on it (duh, why would you do
that?), RubyGems doesn't know about the file, so it can't tell Minitest,
so Minitest doesn't automatically require it. This means I had to
manually require and insert the plugin in our integration test. I've
left comments about that in the test as well.
Ugh.