Make the Rack::SSL middleware configurable #3141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
added a commit
that referenced
this pull request
Sep 27, 2011
Make the Rack::SSL middleware configurable
|
Thanks for also patching the guides! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rails configuration option "enforce_ssl" is handy but is currently unable to take advantage of features in Rack::SSL, such as passing a Proc to the middleware to exclude certain urls or url patterns from being redirected to https. This patch allows the user to specify ssl_options which are passed directly to the Rack::SSL middleware on initialization if enforce_ssl is set to true.
Without this patch the user must insert the Rack::SSL middleware onto the stack manually in order to add configuration options.
This patch also adds a test for the passing of options to the Rack::SSL middleware and adds mention of the ability to configure Rack::SSL to configuring.textile.