Fixes count for collection object when there's explicit rollback in callbacks #31488
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
Sayanc93
force-pushed
the
fix-collection-rollback
branch
from
18f0bfe
to
588aece
Compare
|
Hey @Sayanc93 thanks for the PR! Can you address the failing tests? |
when there's an explicit ActiveRecord::Rollback in a callback and change the count of the collection obect without any regard to the callback specification. This used to happen because ActiveRecord::Rollback used to be silently swallowed and the rest of the pipeline triggered commit from it's previously assigned data values. For example: @model.collection.create would yield 1 even if there's ActiveRecord::Rollback in after_create callback of Collection model. This PR fixes the problem and makes the count consistent if there's a rollback on a collection object. Fixes rails#28836 and rails#28536
Sayanc93
force-pushed
the
fix-collection-rollback
branch
from
588aece
to
f87bb4d
Compare
In `_create_record`, explicit `transaction` block requires rollback handling manually when `insert_record` is failed. We need to handle it in `_create_record`, not in `insert_record`, since our test cases expect a record added to target and returned even if `insert_record` is failed, Closes #31488.
Previously collection models used to get persisted even
when there's an explicit ActiveRecord::Rollback in a
callback and change the count of the collection obect
without any regard to the callback specification.
This used to happen because ActiveRecord::Rollback used
to be silently swallowed and the rest of the pipeline triggered
commit from it's previously assigned data values.
For example:
@model.collection.create would yield 1 even if there's ActiveRecord::Rollback
in after_create callback of Collection model.
This PR fixes the problem and makes the count consistent
if there's a rollback on a collection object.
Fixes #28836 and #28536