assert_nothing_raised not required here, we can assert directly for the actual result #31492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prathamesh-sonpatki
force-pushed
the
rm-assert-nothing-raised
branch
from
8378b46
to
f6a38b7
Compare
eileencodes
requested changes
Dec 18, 2017
| developer.ratings.includes(comment: :post).where(posts: { id: 1 }).exists? | ||
| end | ||
| developer = developers(:david) | ||
| assert_equal false, developer.ratings.includes(comment: :post).where(posts: { id: 1 }).exists? |
There was a problem hiding this comment.
@prathamesh-sonpatki can you change this to use assert_predicate instead? I think it reads better that way.
There was a problem hiding this comment.
Used assert_not_predicate.
prathamesh-sonpatki
force-pushed
the
rm-assert-nothing-raised
branch
from
f6a38b7
to
eaf639c
Compare
|
@eileencodes Done! |
eileencodes
approved these changes
Dec 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @kamipo