Use SHA-1 for non-sensitive digests by default #31651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of providing a configuration option to set the hash function, switch to SHA-1 for new apps and allow upgrading apps to opt in later via `new_framework_defaults_5_2.rb`.
|
r? @sgrif (@rails-bot has picked a reviewer for you, use r? to override) |
eugeneius
force-pushed
the
use_sha1_digests
branch
from
594f4e5
to
d034f48
Compare
georgeclaghorn
approved these changes
Jan 9, 2018
This was referenced Oct 11, 2019
ghiculescu
reviewed
May 21, 2020
| @@ -672,6 +672,8 @@ There are a few configuration options available in Active Support: | |||
|
|
|||
| * `config.active_support.time_precision` sets the precision of JSON encoded time values. Defaults to `3`. | |||
|
|
|||
| * `config.active_support.use_sha1_digests` specifies whether to use SHA-1 instead of MD5 to generate non-sensitive digests, such as the ETag header. Defaults to false. | |||
There was a problem hiding this comment.
i think this defaults to true. #39386
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #31289.
Instead of providing a configuration option to set the hash function, switch to SHA-1 for new apps and allow upgrading apps to opt in later via
new_framework_defaults_5_2.rb.@georgeclaghorn, does this address your concern from #31289 about cache invalidations for existing apps? Upgrading to 5.2 wouldn't change anything, but flipping the setting later would still invalidate every key. If busting the cache is a complete no-go, you could just never do that.