Remove label 'work in progress' for AM and AV guides #31883
Conversation
|
(@rails-bot has picked a reviewer for you, use r? to override) |
I've reviewed "Active Model Basics" and "Action View Overview" guides and looks like they have good enough information and don't have errors. This commit removes label 'work in progress' for these guides.
bogdanvlviv
force-pushed
the
remove-label-in-porgress-for-M-V-guides
branch
from
289eafb
to
6f34f7d
Compare
bogdanvlviv
changed the title
|
Just because they don't have errors and are readable doesn't mean they aren't still a work in progress. @fxn do you know what's missing from these guides? 😊 |
|
Thanks for the PR. If they’re still in progress we can always revert 😉 |
|
@schneems it doesn't work this way. You apply when you know as reviewer of the patch that the patch has to be applied. You have to validate the patch. I admit it has been months since this ticket was opened and have not responded and appreciate that you are helping dynamizing the issues, though. I'll revert, and we'll apply when we know it has to be in. |
|
@fxn What would make the ActionView guides good enough to remove the 'work in progress' label? Should all helpers be documented? |
I've reviewed "Active Model Basics" and "Action View Overview" guides
and looks like they have good enough information and don't have errors.
This PR removes label 'work in progress' for these guides.
History for rails/guides/source/active_model_basics.md
History for rails/guides/source/action_view_overview.md