Fix RedisCacheStore #write_multi to correctly store entries #31886
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31884.
Before, values were incorrectly stored as strings like
"#<ActiveSupport::Cache::Entry:0x007fd63671af48>"
. So now they are stored correctly.I created a test with explicit
expires_in
asnil
to test this code pathrails/activesupport/lib/active_support/cache/redis_cache_store.rb
Lines 361 to 364 in 5d19995
expires_in
hererails/activesupport/test/cache/stores/redis_cache_store_test.rb
Line 92 in 5d19995