Fix test_counter_cache_with_touch_and_lock_version failure
#31919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamipo
reviewed
Feb 7, 2018
| @@ -415,14 +415,16 @@ def test_counter_cache_with_touch_and_lock_version | |||
| assert_equal 1, car.lock_version | |||
|
|
|||
| previously_car_updated_at = car.updated_at | |||
| car.wheels.first.update(size: 42) | |||
There was a problem hiding this comment.
The failure is due to datetime rounding, but daf15f5 didn't fix that.
that is caused by this line, so we need to address this line only.
bogdanvlviv
force-pushed
the
fix-test_counter_cache_with_touch_and_lock_version
branch
from
18e3b04
to
4444294
Compare
bogdanvlviv
deleted the
fix-test_counter_cache_with_touch_and_lock_version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://travis-ci.org/rails/rails/jobs/338338927#L1043
Related to daf15f5
r? @kamipo