Use heredoc with credentials template #31942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @kaspth (@rails-bot has picked a reviewer for you, use r? to override) |
y-yagi
reviewed
Feb 9, 2018
| "# aws:\n# access_key_id: 123\n# secret_access_key: 345\n\n" + | ||
| "# Used as the base secret for all MessageVerifiers in Rails, including the one protecting cookies.\n" + | ||
| "secret_key_base: #{SecureRandom.hex(64)}" | ||
| <<-YAML.strip_heredoc |
There was a problem hiding this comment.
Please add require "active_support/core_ext/string/strip".
There was a problem hiding this comment.
encrypted command also has the same issue. Can you fix?
There was a problem hiding this comment.
@y-yagi Thanks for the comments. I've fixed them based on your advices.
* Use heredoc with credentials template. * Fix indentation for aws config
yhirano55
force-pushed
the
use_heredoc_with_credentials_template
branch
from
c74baa0
to
1469657
Compare
y-yagi
approved these changes
Feb 9, 2018
|
Thanks! |
|
@yhirano55 thanks! @y-yagi don't forget to backport to 5-2-stable 😊 |
y-yagi
added a commit
that referenced
this pull request
Feb 9, 2018
…_template Use heredoc with credentials template
|
👍 Backported: d1e3302 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary