Respect --force option for config/master.key

[claudiob]

This is similar to #30700 which ensures the --quiet option of rails new is respected by the MasterKeyGenerator (missing from #30067).

Before this commit, running rails new app --force would still prompt the user what to do with the conflict in config/master.key:

              …
   identical  config/locales/en.yml
    conflict  config/master.key
Overwrite /Users/claudiob/Desktop/pizza/config/master.key? (enter "h" for help) [Ynaqdh]

After this commit, config/master.key is overwritten:

           …
identical  config/locales/en.yml
    force  config/master.key
   append  .gitignore

The newly added test generates an app and then generates it again with --force. Without this commit, the test would just wait forever for user input.

[claudiob]

My suggestion would be to backport this to 5.2 as well.

[y-yagi]

Backported 74976e8

[claudiob]

Mmmh @y-yagi now that I think about it, I see another issue related to this code.

On one hand, it's true that --force should be respected.
On the other hand, if we replace the master key (which is not under git control), we won't be able to decrypt config/credentials.yml.enc anymore.

I can see two solutions here:

1. Using --force does not replace config/master.key if it's already present. Does not even ask for it, simply leaves it there

or

2. Using --force also regenerates config/credentials.yml.enc. Currently this does not happen because this code introduced in f7e3c68 does not respect the --force option:

def add_credentials_file_silently(template = nil)
  unless credentials.content_path.exist?
    credentials.write(credentials_template)
  end
end

What's your opinion?

[y-yagi]

Thanks. I think the first solution is good.
It seems to be sufficient if add a file existence check to add_key_file_silently like add_key_file, what about it?
https://github.com/rails/rails/blob/cfcb92f9eaf78daefe21335bcabf813842c0ab07/railties/lib/rails/generators/rails/encryption_key_file/encryption_key_file_generator.rb#L28..L30

[claudiob]

@y-yagi That sounds good. Go for it! 🏃