Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in new RedisCacheStore docs #31967

Closed
wants to merge 1 commit into from
Closed

Typo in new RedisCacheStore docs #31967

wants to merge 1 commit into from

Conversation

josephpage
Copy link
Contributor

In the edge documentation I found that the wrong keyword is used for this parameter.
Instead of cache: false, it should be compress: false

Thanks !

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@rails-bot
Copy link

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against 5-2-stable. Please double check that you specified the right target!

@rafaelfranca rafaelfranca changed the base branch from 5-2-stable to master February 12, 2018 19:44
@rafaelfranca
Copy link
Member

Can you rebase against the master branch? All PRs should be to the master branch unless it is an issue only in the stable branch and this is not the case here.

@jeremy
Copy link
Member

jeremy commented Feb 12, 2018

Cherry-picked c01c38e ❤️ Thanks @josephpage !

@jeremy jeremy closed this Feb 12, 2018
jeremy pushed a commit that referenced this pull request Feb 12, 2018
@josephpage
Copy link
Contributor Author

Thanks @jeremy and @rafaelfranca !

bogdanvlviv pushed a commit to bogdanvlviv/rails that referenced this pull request Feb 12, 2018
jeremy pushed a commit that referenced this pull request Feb 12, 2018
@josephpage josephpage deleted the typo-redis-compress branch February 13, 2018 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants