Add ActiveStorage::Blob.unattached scope #31970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,6 +27,8 @@ class ActiveStorage::Blob < ActiveRecord::Base | |||
|
|
|||
| has_many :attachments | |||
|
|
|||
| scope :unattached, -> { left_joins(:attachments).where(ActiveStorage::Attachment.table_name => { blob_id: nil }) } | |||
There was a problem hiding this comment.
Don't we need an index in blob_id now? The index we have has :record_type, :record_id and :name before the blob_id so the left-most rule will not apply anymore.
There was a problem hiding this comment.
There is an index already
.references adds index by default (http://edgeapi.rubyonrails.org/classes/ActiveRecord/ConnectionAdapters/SchemaStatements.html#method-i-add_reference).
There was a problem hiding this comment.
oh cool! I always forget that
rafaelfranca
added a commit
that referenced
this pull request
Feb 13, 2018
Add ActiveStorage::Blob.unattached scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One blob can be attached to multiple records
(with
has_(one/many)_attached :thingy, dependent: false) so it is needed to manually do garbage collecting of orphaned blobs whenall related records are destroyed. Also there is a possibility of orphaned records, when for example, user
abandones to submit a form with attachments.
So it seems useful and convenient for me to have
unattachedscope onBlobto simplify said manual garbage collecting. So, GC of orphaned records within some rake task can be done:r? @georgeclaghorn @dhh