PERF: dedupe scanned route fragments #31999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per: https://bugs.ruby-lang.org/issues/13077 String @- will dedupe strings. This takes advantage of this by deduping route fragments that are full of duplication usually. For Discourse: Before: Total allocated: 207574305 bytes (2214916 objects) Total retained: 36470010 bytes (322194 objects) After Total allocated: 207556847 bytes (2214711 objects) Total retained: 36327973 bytes (318627 objects) <- object that GC can not collect So we save 3500 or so RVALUES this way, not the largest saving in the world, but worth it especially for large route files.
|
r? @eileencodes (@rails-bot has picked a reviewer for you, use r? to override) |
|
This PR broke a lot of tests. Reverting |
|
Sorry about that, will have a careful look and correct it.
…On Fri, Feb 16, 2018 at 7:43 AM, Rafael França ***@***.***> wrote:
This PR broke a lot of tests. Reverting
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#31999 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAUXX9dNi59kwCGMSpog6_Ie4imFcE4ks5tVJbigaJpZM4SGUBN>
.
|
|
@rafaelfranca I fixed it in Confirmed tests are running in local, can you merge it in or do you want me to redo the PR? |
|
I can manually apply the two patches. Doing |
|
done! |
rafaelfranca
added a commit
that referenced
this pull request
Feb 15, 2018
This reverts commit f282f37.
|
thanks heaps, and apologies!
…On Fri, Feb 16, 2018 at 9:35 AM, Rafael França ***@***.***> wrote:
done!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#31999 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAUXZrbBx-Bs65npHGxGLBc37YJ26Wzks5tVLE1gaJpZM4SGUBN>
.
|
|
Since master is already 6.0, will we stop supporting for 2.2.x? |
|
Oh ... I think we should otherwise, just monkey patch in 2.2 is EOL in March 31, 2018, I would drop it for master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per: https://bugs.ruby-lang.org/issues/13077 String @- will dedupe strings.
This takes advantage of this by deduping route fragments that are full of duplication usually.
For Discourse:
Before:
Total allocated: 207574305 bytes (2214916 objects)
Total retained: 36470010 bytes (322194 objects)
After
Total allocated: 207556847 bytes (2214711 objects)
Total retained: 36327973 bytes (318627 objects) <- object that GC can not collect
So we save 3500 or so RVALUEs this way, not the largest saving in the world, but worth it especially for large route files.