Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guides/CHANGELOG.md #32159

Merged

Conversation

bogdanvlviv
Copy link
Contributor

@bogdanvlviv bogdanvlviv commented Mar 3, 2018

To Rails 5.2.0.beta1 was added "Threading and Code Execution in Rails" Guide
by 8bfa617.

To Rails 5.2.0.rc1 was added "Active Storage Overview" Guide
by 48fbc4a.

This commit adds changelogs about adding these guides.
I think it deserves to be mentioned inguides/CHANGELOG.md

To Rails 5.2.0.beta1 was added "Threading and Code Execution in Rails" Guide
by 8bfa617.

To Rails 5.2.0.rc1 was added "Active Storage Overview" Guide
by 48fbc4a.

This commit adds changelogs about adding these guides.
I think it deserves to be mentioned in`guides/CHANGELOG.md`
@rails-bot
Copy link

r? @eileencodes

(@rails-bot has picked a reviewer for you, use r? to override)

@rails-bot
Copy link

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against 5-2-stable. Please double check that you specified the right target!

@kaspth kaspth merged commit 4eb3e70 into rails:5-2-stable Mar 3, 2018
@kaspth
Copy link
Contributor

kaspth commented Mar 3, 2018

Thanks, don't forget [ci skip] too :)

@bogdanvlviv bogdanvlviv deleted the 5-2-stable-update-guide-changelog-file branch March 3, 2018 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants