Deprecate safe_level of ERB.new in Ruby 2.6
#32170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pixeltrix (@rails-bot has picked a reviewer for you, use r? to override) |
kamipo
reviewed
Mar 5, 2018
| @@ -63,7 +63,12 @@ def migration_template(source, destination, config = {}) | |||
| numbered_destination = File.join(dir, ["%migration_number%", base].join("_")) | |||
|
|
|||
| create_migration numbered_destination, nil, config do | |||
| ERB.new(::File.binread(source), nil, "-", "@output_buffer").result(context) | |||
| match = ERB.version.match(/\Aerb\.rb \[(?<version>[^ ]+) /) | |||
| if match && match[:version] >= '2.2.0' # Ruby 2.6+ | |||
There was a problem hiding this comment.
I made a basic error 💦 I fixed it.
kamipo
reviewed
Mar 5, 2018
tasks/release.rb
Outdated
| puts ERB.new(template, nil, "<>").result(binding) | ||
|
|
||
| match = ERB.version.match(/\Aerb\.rb \[(?<version>[^ ]+) /) | ||
| if match && match[:version] >= '2.2.0' # Ruby 2.6+ |
### Summary
In a Rails application using Ruby 2.6.0-dev, when running `bin/rails g migration`
with `RUBYOPT=-w`, an ERB deprecation warnings will be displayed.
```console
% ruby -v
ruby 2.6.0dev (2018-03-03 trunk 62644) [x86_64-darwin17]
% bin/rails -v
Rails 6.0.0.alpha
% RUBYOPT=-w bin/rails g migration create_foos
(snip)
/Users/koic/src/github.com/rails/rails/railties/lib/rails/generators/migration.rb:66:
warning: Passing safe_level with the 2nd argument of ERB.new is
deprecated. Do not use it, and specify other arguments as keyword
arguments.
/Users/koic/src/github.com/rails/rails/railties/lib/rails/generators/migration.rb:66:
warning: Passing trim_mode with the 3rd argument of ERB.new is
deprecated. Use keyword argument like ERB.new(str, trim_mode: ...)
instead.
/Users/koic/src/github.com/rails/rails/railties/lib/rails/generators/migration.rb:66:
warning: Passing eoutvar with the 4th argument of ERB.new is
deprecated. Use keyword argument like ERB.new(str, eoutvar: ...)
instead.
create db/migrate/20180304002144_create_foos.rb
```
This PR suppresses the above deprecation warnings in Ruby 2.6.0-dev.
This warning is due to the interface of `ERB.new` will change from Ruby 2.6.
> Add :trim_mode and :eoutvar keyword arguments to ERB.new.
> Now non-keyword arguments other than first one are softly deprecated
> and will be removed when Ruby 2.5 becomes EOL. [Feature rails#14256]
https://github.com/ruby/ruby/blob/2311087b685e8dc0f21f4a89875f25c22f5c39a9/NEWS#stdlib-updates-outstanding-ones-only
The following addresses are related Ruby's commit.
ruby/ruby@cc777d0
Also this PR will change `ERB.new` used in `tasks/release.rb`.
### Other Information
This PR uses `ERB.version` to switch `ERB.new` interface. Because Rails 6
supports multiple Ruby versions (Ruby 2.4.1 or higher), it need to
use the appropriate interface.
Using `ERB.version` instead of `RUBY_VERSON` is based on the following patch.
ruby/ruby#1826
This patch is built into Ruby.
ruby/ruby@40db89c
koic
force-pushed
the
deprecate_safe_level_of_erb_new_in_ruby_2_6
branch
from
b70f5cd
to
e8be4f0
Compare
kamipo
added a commit
that referenced
this pull request
Mar 5, 2018
…n_ruby_2_6 Deprecate safe_level of `ERB.new` in Ruby 2.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In a Rails application using Ruby 2.6.0-dev, when running
bin/rails g migrationwithRUBYOPT=-w, an ERB deprecation warnings will be displayed.This PR suppresses the above deprecation warnings in Ruby 2.6.0-dev.
This warning is due to the interface of
ERB.newwill change from Ruby 2.6.https://github.com/ruby/ruby/blob/2311087b685e8dc0f21f4a89875f25c22f5c39a9/NEWS#stdlib-updates-outstanding-ones-only
The following addresses are related Ruby's commit.
ruby/ruby@cc777d0
Also this PR will change
ERB.newused intasks/release.rb.Other Information
This PR uses
ERB.versionto switchERB.newinterface. Because Rails 6 supports multiple Ruby versions (Ruby 2.4.1 or higher), it need to use the appropriate interface.Using
ERB.versioninstead ofRUBY_VERSONis based on the following patch.ruby/ruby#1826
This patch is built into Ruby.
ruby/ruby@40db89c