-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update some i18n references in guides #32182
Update some i18n references in guides #32182
Conversation
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
Summary of changes:
I think a lot more could be done to update this guide, just skimming it I found these issues but there are probably more. I think adding a section on translating content is important because it's a topic that comes up a lot, and can be very confusing for people unaware of the distinction with the standard I18n API. Also: I'm aware that technically you can store strings in the database with i18n using the ActiveRecord backend, but it's an edge use case and gems like Globalize and Mobility are much more commonly used for this. |
@svenfuchs Since you were the original author of this guide, maybe you could comment on the changes? 😄 |
48f33c8
to
b15722c
Compare
This class no longer exists.
This reference doesn't really make sense here, since Globalize is primarily focused on storing translated content (now anyway).
b15722c
to
b864169
Compare
There were some formatting issues, fixed them in 5cb14f0. |
@shioyama thanks! |
Thanks! I don't suppose there's any chance this could get cherry-picked to 5-2-stable as well? Or should I make a PR to that branch for that? |
* Remove reference to Globalize::Backend::Static as this class no longer exists. * Remove reference to google group * Remove confusing reference to Globalize3 * Add section on translating stored content [ci skip]
👍 Thanks! |
Thanks for all your great work in the I18n space, @shioyama! ❤️ |
😊 |
The
Globalize::Backend::Static
class no longer exists in the globalize gem, so far as I can tell. I think this section of the guide is way out of date.