can't use joins in has_one scope block?

[InteNs]

Trying to use a scope with joins() doesn't include that join in the generated sql, be it directly, via named_scopes or via default_scopes.

Below is a minimal example that reproduces this issue.
This is causing trouble because i need to scope the primary_marking based on an attribute from it's marking_code (there would be a .where(...) following the join

Steps to reproduce

class DamageIncident < ApplicationRecord
  has_one :primary_marking, -> { joins(:marking_code) }
end

class PrimaryMarking < ApplicationRecord
  belongs_to :marking_code
end

irb> DamageIncident.joins(:primary_marking)

Expected behavior

SELECT damage_incidents.*
FROM damage_incidents
  INNER JOIN primary_markings
    ON primary_markings.damage_incident_id = damage_incident.id
  INNER JOIN marking_codes
    ON primary_markings.marking_code_id = marking_codes.id

Actual behavior

SELECT damage_incidents.*
FROM damage_incidents
  INNER JOIN primary_markings
    ON primary_markings.damage_incident_id = damage_incident.id

System configuration

Rails version: Rails 5.1.4

Ruby version: ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-darwin16]

[kamipo]

This should be fixed by #29413.
Can you try to reproduce it on master?

[rails-bot]

This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails team are limited, and so we are asking for your help.
If you can still reproduce this error on the 5-2-stable branch or on master, please reply with all of the information you have about it in order to keep the issue open.
Thank you for all your contributions.

[InteNs]

confirmed fixed on latest rails version!