Update "Upgrading from Rails 5.1 to Rails 5.2" [ci skip] #32250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @schneems (@rails-bot has picked a reviewer for you, use r? to override) |
bogdanvlviv
force-pushed
the
add-info-about-exprity-of-siigned-cookies-to-upgrading-to-5-2
branch
5 times, most recently
from
abb30a9
to
1c1a6d1
Compare
pixeltrix
suggested changes
Mar 14, 2018
guides/source/configuring.md
Outdated
| @@ -502,6 +502,9 @@ Defaults to `'signed cookie'`. | |||
| * `config.action_dispatch.cookies_rotations` allows rotating | |||
| secrets, ciphers, and digests for encrypted and signed cookies. | |||
|
|
|||
| * `config.action_dispatch.use_authenticated_cookie_encryption` controls encrypted cookies to use AES-256-GC | |||
| authenticated encryption. It defaults to `true`. | |||
There was a problem hiding this comment.
Change to:
* `config.action_dispatch.use_authenticated_cookie_encryption` controls whether signed and encrypted cookies use the AES-256-GCM cipher or the older AES-256-CBC cipher. It defaults to true.There was a problem hiding this comment.
Thanks. It is more clear.
Add section "Expiry in signed or encrypted cookie is now embedded in the cookies values" to `master` since it should always be in the guides, not only for version 5.2. Add info about `config.action_dispatch.use_authenticated_cookie_encryption` to the "Configuring Rails Applications" guide. It was committed straight to `5-2-stable` since we don't need this functionality in 6.0. Related to b25fcbc.
bogdanvlviv
force-pushed
the
add-info-about-exprity-of-siigned-cookies-to-upgrading-to-5-2
branch
from
1c1a6d1
to
c8a22bb
Compare
pixeltrix
approved these changes
Mar 14, 2018
|
Thanks @bogdanvlviv 👍 |
bogdanvlviv
deleted the
add-info-about-exprity-of-siigned-cookies-to-upgrading-to-5-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add section "Expiry in signed or encrypted cookie is now embedded in the cookies values"
to
mastersince it should always be in the guides, not only for version 5.2.Add info about
config.action_dispatch.use_authenticated_cookie_encryptionto the "Configuring Rails Applications" guide.
It was committed straight to
5-2-stablesince we don't need thisfunctionality in 6.0. Related to b25fcbc.