Fix failing QuotingTest#test_quoted_time_utc
#32284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixeltrix
reviewed
Mar 19, 2018
| @@ -72,7 +72,7 @@ def test_quoted_time_utc | |||
| t = Time.now.change(usec: 0) | |||
|
|
|||
| expected = t.change(year: 2000, month: 1, day: 1) | |||
| expected = expected.getutc.to_s(:db).sub("2000-01-01 ", "") | |||
| expected = expected.getutc.to_s(:db).sub(/\A\d\d\d\d-\d\d-\d\d /, "") | |||
There was a problem hiding this comment.
Can you change it to this:
expected = t.getutc.change(year: 2000, month: 1, day: 1)
expected = expected.to_s(:db).sub("2000-01-01 ", "")It makes the expected value less permissive and the reduces the chance of it passing when it should fail - thanks!
There was a problem hiding this comment.
@pixeltrix Fixed. Thanks for the clarifying this.
This test fails in specific time. Example: If run this test on the machine with time 01:00 am UTC+2, this test will fail. Changing representing of 2000-01-01 01:00 am UTC+2 to UTC+0 change the day, month and even year in our case, so substitution `"2000-01-01 "` to `""` isn't possible. ``` Failure: ActiveRecord::ConnectionAdapters::QuotingTest#test_quoted_time_utc Expected: "1999-12-31 23:01:27" Actual: "23:01:27" ``` Related to 7c479cb
bogdanvlviv
force-pushed
the
fix-failing-test-test_quoted_time_utc
branch
from
c05f04a
to
7daa6f4
Compare
|
@bogdanvlviv thanks! I've backported to all 5.x branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test fails in specific time.
Example:
f run this test on the machine with time 01:00 am UTC+2,
this test will fail.
Changing representing of 2000-01-01 01:00 am UTC+2 to UTC+0 change
the day, month and even year in our case,
so substitution
"2000-01-01 "to""isn't possible.Related to 7c479cb
r? @pixeltrix