Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci skip] Capitalize sentence of first char in AS guide #32392

Conversation

yhirano55
Copy link
Contributor

Summary

I found grammer mistake.

@rails-bot
Copy link

r? @kamipo

(@rails-bot has picked a reviewer for you, use r? to override)

@pixeltrix pixeltrix merged commit bc5149b into rails:master Mar 31, 2018
@pixeltrix
Copy link
Contributor

@yhirano55 thanks! 👍

@yhirano55 yhirano55 deleted the capitalize_sentence_of_first_char_in_as_guide branch March 31, 2018 12:56
@fxn
Copy link
Member

fxn commented Mar 31, 2018

👎 on this edit.

We use this often, the point is a listing is not a paragraph separator.

The structure of that text is:

Thus, after a simple require like [listing], objects do not even respond [...]

That is one sentence, cannot be broken. In mathematics you would put the comma after the formula, as in the template above. In programming docs the punctuation is conventionally omitted and introducing colons more common.

@pixeltrix
Copy link
Contributor

@fxn you're right - the diff view made it seem like a standalone sentence but after expanding I can see the context.

@yhirano55
Copy link
Contributor Author

@fxn Oh, sorry. I understood. please revert this change.

@pixeltrix
Copy link
Contributor

Reverted in f4680e4

@yhirano55
Copy link
Contributor Author

Thanks. I'll be more careful.

@fxn
Copy link
Member

fxn commented Mar 31, 2018

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants