Use consistent spacing in actionview helper docs #32406
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @georgeclaghorn (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
| # # => [{name: 'country[name]', value: 'Denmark'}] | ||
| # to_form_params(country: { name: 'Denmark' }) |
There was a problem hiding this comment.
This ordering doesn't seem right? 😊
There was a problem hiding this comment.
Oh, git add -p 😭
There was a problem hiding this comment.
@kaspth Ok, that's fixed now.
The spacing in these comments is fairly inconsistent. Array argument contents are often separated with a space from the array literal brackets but in several cases the Hash literal curly braces are tangent to their contents which makes the documentation harder to read in some cases.
olivierlacan
force-pushed
the
actionview-helpers-docs-consistent-spacing
branch
from
7820a0b
to
a075625
Compare
|
Thanks, Olivier! |
The spacing in the actionview comments is fairly inconsistent.
Array argument contents are often separated with a space from the array literal
brackets but in several cases the Hash literal curly braces are tangent
to their contents which makes the documentation harder to read in some
cases.
This PR addresses this.