Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .new with multiple through associations #32514

Merged

Conversation

samdec
Copy link
Contributor

@samdec samdec commented Apr 10, 2018

Summary

This fixes a bug with building an object that has multiple has_many :through
associations through the same object.
Previously, when building the object via .new, the intermediate object
would be created instead of just being built.

The associated issue is: #32511

Other information

Here's an example:
Given a GameBoard, that has_one :owner and :collection through: game.
The following line would cause a Game object to be created in the
database.

GameBoard.new(owner: some_owner, collection: some_collection)

Whereas, if passing only one of those associations into .new would
cause the game object to be built and not created in the database.

Now the above code will only build the Game object, and not save it.

This fixes a bug with building an object that has multiple
`has_many :through` associations through the same object.
Previously, when building the object via .new, the intermediate
object would be created instead of just being built.

Here's an example:
Given a GameBoard, that has_one Owner and Collection through Game.
The following line would cause a game object to be created in the
database.

    GameBoard.new(owner: some_owner, collection: some_collection)

Whereas, if passing only one of those associations into `.new` would
cause the Game object to be built and not created in the database.

Now the above code will only build the Game object, and not save it.
@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@kamipo kamipo merged commit aa941c9 into rails:master Apr 21, 2018
kamipo added a commit that referenced this pull request Apr 21, 2018
kamipo added a commit that referenced this pull request Apr 21, 2018
…ations-build-bug

Fix .new with multiple through associations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants