Fix .new with multiple through associations #32514
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a bug with building an object that has multiple
has_many :through
associations through the same object.
Previously, when building the object via
.new
, the intermediate objectwould be created instead of just being built.
The associated issue is: #32511
Other information
Here's an example:
Given a
GameBoard
, thathas_one
:owner
and:collection
through: game
.The following line would cause a
Game
object to be created in thedatabase.
Whereas, if passing only one of those associations into
.new
wouldcause the
game
object to be built and not created in the database.Now the above code will only build the Game object, and not save it.