Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guides/testing: Pluralize controller and helper class names. #32575

Merged
merged 1 commit into from
Apr 20, 2018
Merged

guides/testing: Pluralize controller and helper class names. #32575

merged 1 commit into from
Apr 20, 2018

Conversation

ybakos
Copy link
Contributor

@ybakos ybakos commented Apr 14, 2018

The Rails convention for controllers and helpers is plural, except where
intentionally singular. Pluralize the controller and helper class names,
to match convention.

Summary

Minor change to guides/testing.md: pluralizing UserHelper, UserHelperTest, and UserControllerTest.

Thanks for all things Rails!

The Rails convention for controllers and helpers is plural, except where
intentionally singular. Pluralize the controller and helper class names,
to match convention.
@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@rafaelfranca rafaelfranca merged commit b8cd930 into rails:master Apr 20, 2018
rafaelfranca added a commit that referenced this pull request Apr 20, 2018
…names

guides/testing: Pluralize controller and helper class names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants