Fix name of the test added by #32613 #32642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixeltrix
reviewed
Apr 19, 2018
| @@ -725,7 +725,7 @@ def test_all_uninfluenced_by_time_zone_lookups_delegated_to_tzinfo | |||
| assert_not_includes all_zones, galapagos | |||
| end | |||
|
|
|||
| def test_all_not_raises_exception_with_mizzing_tzinfo_data | |||
| def test_all_doesnt_raise_exception_with_missing_tzinfo_data | |||
There was a problem hiding this comment.
LOL, how did I miss that - thanks 👍
There was a problem hiding this comment.
thanks for the review. will we backport this to 5-2-stable?
There was a problem hiding this comment.
Done in e4ab3c1 - thanks again
pixeltrix
added a commit
that referenced
this pull request
Apr 20, 2018
Fix name of the test added by #32613
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #32613
r? @pixeltrix