Fix relation merging with skip_query_cache! #32645
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
|
See #32640 (comment) |
Fix relation merging with skip_query_cache!
Fix relation merging with skip_query_cache!
First argument to `assert_equal` should be expected value, second - actual value. Use `assert` in order to assert that `skip_query_cache_value` is truly object since we rely on Ruby semantics. Related to rails#32645
Summary
Allow skip_query_cache to receive an argument, similar to other methods (e.g.
distinct!)Fixes an issue where
ActiveRecord::Relation::Mergertries to send the value to the other relation when it's set https://github.com/rails/rails/blob/master/activerecord/lib/active_record/relation/merger.rb#L76Fixes #32640