Relax assertions in connection config tests #32674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment these two ActiveRecord tests pass with `rake test:sqlite3`, but fail with `ARCONN=sqlite3 bin/test`. `Rails.root` is defined when running `bin/test`, but not when running the rake task. When `Rails.root` is defined, `config[:database]` will look something like `vagrant/rails/activerecord/db/primary.sqlite3` instead of just `db/primary.sqlite3`. (See https://github.com/rails/rails/blob/00caf95e14b90782ab17fbd6d2b930844df99980/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L27) Relaxing `assert_equal` to `assert_match` will allow these tests to pass regardless of how they are run. I do have a question why we need both ways to run tests. I have been using `bin/test` lately, but I see from rails#32426 that this is not the preferred method.
|
(@rails-bot has picked a reviewer for you, use r? to override) |
|
According to #20480, it is for using the minitest plugin. But probably there are still some problems remaining and nobody is working on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment these two ActiveRecord tests pass with
rake test:sqlite3,but fail with
ARCONN=sqlite3 bin/test.Rails.rootis defined when runningbin/test, but not when runningthe rake task. When
Rails.rootis defined,config[:database]willlook something like
vagrant/rails/activerecord/db/primary.sqlite3instead of just
db/primary.sqlite3.rails/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb
Line 27 in 00caf95
Relaxing
assert_equaltoassert_matchwill allow these tests to passregardless of how they are run.
I do have a question why we need both ways to run tests. I have been
using
bin/testlately, but I see from #32426 that this is not the preferredmethod.